Add transfer room ownership feature#6243
Open
nathanael-h wants to merge 2 commits into
Open
Conversation
- POST /api/v1/rooms/:friendly_id/transfer_ownership endpoint, owner-only - GET /api/v1/shared_accesses/:friendly_id/transferable_users endpoint - TransferOwnershipForm with danger alert and radio-button user selection - Red "Transfer Ownership" button in SharedAccess panel alongside share button - Navigates back to /rooms on success (owner loses access to transferred room)
|
Extract UserSearchTable component and useUserSearch hook to eliminate identical table JSX and useQuery blocks across SharedAccessForm and TransferOwnershipForm. Extract search_valid? and search_users helpers in the controller. Fix nested array wrapping in where.not/where(role_id) clauses. Addresses SonarCloud duplication gate failure (6.8% → <3%).
nathanael-h
force-pushed
the
feature/transfer-room-ownership
branch
from
596f310 to
a2a0b11
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello dear maintainers, a colleague asked me if we can change the ownser of a room. I saw in #5178 (comment) that some people are doing this directly in the database. I took a look here and there, and indeed this looks, ower is just a user id, and that's pretty much it. So I started this PR to offer a more user friendly way to do this. To be transparent, I used the help of claude. I also tested this on an internal testing BBB 3 instance.
Questions for the maintainers could be:
Fix #6216 and fix #5178